I have at least 1 version from every generation of the game, and to be honest, I'm not really sure which one to call my favorite. The most progress i've made in any game (in terms of percentage of the Pokedex complete) is the Crystal version, with 215 of 251 Pokemon obtained before the battery ran out.
I can't wait for gen 7, and hope that there's more new Pokemon than in X and Y